Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config read only stuff #30

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix config read only stuff #30

merged 2 commits into from
Nov 6, 2023

Conversation

Mixmix00
Copy link
Member

@Mixmix00 Mixmix00 commented Nov 4, 2023 •
edited by rcahoon
Loading

This change is Reviewable

dejabot
dejabot previously approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@dejabot dejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/logging/config in PR title

@Mixmix00 Mixmix00 requested a review from dejabot November 6, 2023 17:30
@Mixmix00 Mixmix00 linked an issue Nov 6, 2023 that may be closed by this pull request
Config Files on robot are read only, and cannot be changed. #31
Closed
@dejabot dejabot changed the title fix logging read only stuff fix config read only stuff Nov 6, 2023
@dejabot
Copy link
Contributor

dejabot commented Nov 6, 2023

LGTM

@Mixmix00
Copy link
Member Author

Mixmix00 commented Nov 6, 2023

LGTM

Could you approve?

@Mixmix00 Mixmix00 merged commit 3d2975a into master Nov 6, 2023
6 checks passed
@Mixmix00 Mixmix00 deleted the (max)-hockeyplayer-fix-configui branch November 6, 2023 20:13
@Mixmix00 Mixmix00 mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejabot dejabot dejabot approved these changes

Assignees

@dejabot dejabot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config Files on robot are read only, and cannot be changed.
2 participants
@Mixmix00 @dejabot